Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert rbac optim #2348

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Revert rbac optim #2348

merged 6 commits into from
Sep 26, 2024

Conversation

jkhelil
Copy link
Member

@jkhelil jkhelil commented Sep 26, 2024

Changes

CreateResource function is ensuring rbac resource for opensift namespaces. When implemented through concurrency, we observed unstability due the fact that concurrent workers tries to update a shared object clusterinterceptor cluster role binding. concurrency seems not bring improvement in performance, and bring unstability
The fix reverts concurrency implementation and fixes the creates resource function to not block the hole reconciliation when an issue is observed for one namespace

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 26, 2024
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 26, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 54.8% 0.0% -54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 45.6% 0.0% -45.6

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 54.8% 0.0% -54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 45.6% 0.0% -45.6

@savitaashture
Copy link
Contributor

savitaashture commented Sep 26, 2024 •
edited
Loading

Tested locally by upgrading from release-v0.71.x to this PR changes
Steps:

  • Installed Operator from release-v0.71.x branch
  • Created tls eventlistener under releasetest-upgrade-tls ns and verified its working by sending request
  • Upgraded Operator with this PR changes
  • Observed that releasetest-upgrade-tls namespace has not removed from openshift-pipelines-clusterinterceptors clusterrolebinding
  • Sent request to EL and verified its success

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@savitaashture
Copy link
Contributor

cc @PuneetPunamiya

@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@tekton-robot tekton-robot merged commit 1b02a97 into tektoncd:main Sep 26, 2024
8 checks passed
@jkhelil
Copy link
Member Author

jkhelil commented Sep 26, 2024

/cherry-pick release-v0.73.x

@tekton-robot
Copy link
Contributor

@jkhelil: new pull request created: #2349

In response to this:

/cherry-pick release-v0.73.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkhelil @tekton-robot @savitaashture @PuneetPunamiya